Skip to content

Add touch examples #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 5, 2017
Merged

Add touch examples #171

merged 8 commits into from
Feb 5, 2017

Conversation

ionciubotaru
Copy link
Contributor

Adding example folder will help other users to implement new specific ESP32 functions

@me-no-dev
Copy link
Member

ok, this is totally wrong in Arduino perspective.
Examples for ESP32 need to go into libraries/ESP32/examples/ and folder name MUST match the .ino name. libraries/ESP32/ need to have the proper files in order to be discoverable in Arduino IDE

@ionciubotaru
Rename examples/01.Touch/touchIntrrerupt.ino to examples/01.Touch/tou…
ad788e2 
…chIntrerrupt/touchIntrrerupt.ino
@ionciubotaru
Rename examples/01.Touch/touchIntrerrupt/touchIntrrerupt.ino to libra…
5dffe49 
…ries/Touch/examples/touchIntrrerupt/touchIntrrerupt.ino
@ionciubotaru
Rename libraries/Touch/examples/touchIntrrerupt/touchIntrrerupt.ino t…
c14d3b4 
…o libraries/ESP32/examples/Touch/touchIntrerrupt/touchIntrrerupt.ino
@ionciubotaru
Copy link
Contributor Author

fixed

@me-no-dev
Copy link
Member

see here how the folder should look like ;) needs to have the src folder, library.properties and so on

@me-no-dev
Copy link
Member

also please capitalize the name of the sketch (all sketches start with capital letter)

me-no-dev
me-no-dev reviewed Feb 5, 2017
View reviewed changes
libraries/ESP32/examples/Touch/touchIntrerrupt/touchIntrrerupt.ino Outdated
void setup() {
Serial.begin(115200);
delay(1000); // give me time to bring up serial monitor
printf("\n ESP32 Touch Interrupt Test\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be Serial.println("\nESP32 Touch Interrupt Test");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ionciubotaru
Update touchIntrrerupt.ino
635f806
@ionciubotaru
Rename libraries/ESP32/examples/Touch/touchIntrerrupt/touchIntrrerupt…
4a3f3b4 
….ino to libraries/ESP32/examples/Touch/TouchIntrerrupt/TouchIntrrerupt.ino
@ionciubotaru
Copy link
Contributor Author

fixed all sugestions

@me-no-dev
Copy link
Member

Please please please do pay attention at what you are doing! Do test the sketches that you commit! folder and sketch name are all wrong....

@me-no-dev
Copy link
Member

TouchInterrupt is how it MUST be spelled

@ionciubotaru
Rename libraries/ESP32/examples/Touch/TouchIntrerrupt/TouchIntrrerupt…
0a1277b 
….ino to libraries/ESP32/examples/Touch/TouchInterrupt/TouchInterrupt.ino
@ionciubotaru
Update TouchInterrupt.ino
cb4dd9b
@ionciubotaru
Copy link
Contributor Author

Sorry for mistake, I correct it.
I test the schetch before upload, but with a different name

@me-no-dev me-no-dev merged commit c66b54a into espressif:master Feb 5, 2017
@ionciubotaru ionciubotaru deleted the patch-2 branch February 5, 2017 16:05
brentru pushed a commit to adafruit/arduino-esp32 that referenced this pull request Oct 22, 2024
@ladyada
Merge pull request espressif#171 from ayushsharma82/patch-1
a7abac5 
Fix for running ci-arduino in private repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ionciubotaru @me-no-dev